{"id":48,"date":"2007-01-14T05:00:00","date_gmt":"2007-01-14T13:00:00","guid":{"rendered":"http:\/\/testblog.sapien.com\/index.php\/2007\/01\/14\/make-a-cmdlet-part-5-more-fixes\/"},"modified":"2007-01-14T05:00:00","modified_gmt":"2007-01-14T13:00:00","slug":"make-a-cmdlet-part-5-more-fixes","status":"publish","type":"post","link":"https:\/\/dev.sapien.com\/blog\/2007\/01\/14\/make-a-cmdlet-part-5-more-fixes\/","title":{"rendered":"Make-A-Cmdlet: Part 5, More Fixes"},"content":{"rendered":"

So my cmdlet still isn’t working. This time, I’ve made another “debugging” change to my code, adding this line:<\/font><\/p>\n

For Each ThisName In _Name
 WriteDebug("Attempting to ping " & ThisName)
 WriteObject("SELECT StatusCode FROM Win32_PingStatus WHERE Address = '" & ThisName & "'")<\/strong> Dim Query As SelectQuery
 Query = New SelectQuery("SELECT StatusCode FROM Win32_PingStatus WHERE Address = '" & ThisName & "'")<\/font><\/pre>\n
As you can see, I’ve just added a line to output my WMI query. This results in the following when I run the cmdlet in PowerShell:<\/font><\/p>\n
PS C:\\> get-content c:\\computers.txt | ping-computer
SELECT StatusCode FROM Win32_PingStatus WHERE Address = 'sapienteched'
sapienteched
SELECT StatusCode FROM Win32_PingStatus WHERE Address = 'server2'
server2
SELECT StatusCode FROM Win32_PingStatus WHERE Address = 'localhost'
localhost
SELECT StatusCode FROM Win32_PingStatus WHERE Address = ''<\/font><\/pre>\n
Now I can copy and paste the exact query my code is using into Wbemtest.exe, to test it. I want to try the Server2 query, since I know Server2 should NOT be pingable. When I try it, the query works… but I learn something interesting. The StatusCode property, which is usually 0 for a successful ping, is Null for Server2’s ping. Looking at my code:<\/font><\/p>\n
If result.GetPropertyValue("StatusCode") = 0 Then<\/font><\/pre>\n
I see my mistake. I’m comparing Null to 0, and anything compared to Null is Null… in other words, this comparison doesn’t equal True or False, ir equals Null… which is messing up the logic in my code. I need to use VB.NET’s IsNothing() function to see if the returned value is null or not. Doing so, I recompile, rerun, etc, and get this:<\/font><\/p>\n
PS C:\\> add-pssnapin primaltoys
PS C:\\> get-content c:\\computers.txt | ping-computer
sapienteched
localhost<\/font><\/pre>\n
Notice that I’ve removed my debugging code that wrote out the query; this WORKS! This is what I want! Yay! Here’s my final code for the entire cmdlet (BTW, I know this formatting is a little crazy – hang in because at the end of the series I’ll post the project files; I don’t want to do so until I’m DONE, though):<\/font><\/p>\n
Imports<\/font> System.Management.Automation<\/font><\/font><\/p>\n
Imports<\/font> System.Management<\/font><\/font><\/p>\n
<Cmdlet(VerbsDiagnostic.Ping, <\/font>“Computer”, SupportsShouldProcess:=True)> _<\/font>Public <\/font>Class<\/font><\/font> PingComputerCmd<\/font><\/font><\/font>Inherits<\/font> Cmdlet 
‘<Parameter(Position:=0, Mandatory:=False)> _ <\/font><\/font>‘Public Property Name() As String ’ Get ’ Return “” ’ End Get ’ Set(ByVal value As String) ’ End Set ‘End Property <\/font>Private _Name AsString<\/font>() <\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><Parameter(Position:=0, Mandatory:=<\/font>False, ValueFromPipeline:=True<\/font>)> _<\/font><\/font>Public Property Name() AsString<\/font>() 
Get Return<\/font> _Name 
End Get Set(ByVal value AsString<\/font>()) <\/font><\/font>_Name = valueEnd Set End <\/font>Property <\/font>Protected OverridesSub<\/font> ProcessRecord()
Dim ThisName As StringFor Each ThisName In<\/font> _Name <\/font><\/font>WriteDebug(<\/font>“Attempting to ping “<\/font> & ThisName)<\/font><\/font>Dim Query As<\/font> SelectQuery <\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/p>\n
Query = <\/font>New SelectQuery(“SELECT StatusCode FROM Win32_PingStatus WHERE Address = ‘” & ThisName & “’”<\/font>)<\/font><\/font><\/font><\/p>\n
Dim Searcher As<\/font> ManagementObjectSearcher <\/font><\/font><\/font><\/p>\n
Searcher = <\/font>New<\/font> ManagementObjectSearcher(Query)<\/font><\/font><\/font><\/p>\n
Dim result As<\/font> ManagementObject
For Each result In<\/font> Searcher.Get
If Not IsNothing(result.GetPropertyValue(“StatusCode”)) Then If result.GetPropertyValue(“StatusCode”) = 0 Then <\/font><\/font><\/font><\/p>\n
WriteDebug(<\/font>“Successful ping of “<\/font> & ThisName)<\/font><\/font><\/font><\/p>\n
WriteObject(ThisName)<\/font><\/p>\n
Else <\/font><\/p>\n
WriteDebug(<\/font>“Could not ping “<\/font> & ThisName)<\/font><\/font><\/font><\/p>\n
End IfElse <\/font><\/font><\/font><\/p>\n
WriteDebug(<\/font>“Could not ping “<\/font> & ThisName)<\/font><\/font><\/font><\/p>\n
End If
 <\/font>NextNextEnd <\/font>Sub <\/font><\/font><\/font><\/p>\n
End <\/font>Class<\/font><\/font><\/font><\/p>\n
But stay tuned… there’s still a bit more to learn. And apologies for the formatting… neither Visual Studio nor the blog software really seem to like one another when it comes to copy\/paste… again, I’ll be posting the source code at the end of this series, so just hang in there.<\/font><\/font><\/font> <\/p>\n
 <\/p>\n
<\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/font><\/p>\n","protected":false},"excerpt":{"rendered":"
So my cmdlet still isn’t working. This time, I’ve made another “debugging” change to my code, adding this line:<\/P\n\n\n<\/p>\n","protected":false},"author":2,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"_monsterinsights_skip_tracking":false,"_monsterinsights_sitenote_active":false,"_monsterinsights_sitenote_note":"","_monsterinsights_sitenote_category":0,"footnotes":""},"categories":[2,25],"tags":[],"class_list":["post-48","post","type-post","status-publish","format-standard","hentry","category-general","category-windows-powershell"],"jetpack_featured_media_url":"","_links":{"self":[{"href":"https:\/\/dev.sapien.com\/blog\/wp-json\/wp\/v2\/posts\/48","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/dev.sapien.com\/blog\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/dev.sapien.com\/blog\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/dev.sapien.com\/blog\/wp-json\/wp\/v2\/users\/2"}],"replies":[{"embeddable":true,"href":"https:\/\/dev.sapien.com\/blog\/wp-json\/wp\/v2\/comments?post=48"}],"version-history":[{"count":0,"href":"https:\/\/dev.sapien.com\/blog\/wp-json\/wp\/v2\/posts\/48\/revisions"}],"wp:attachment":[{"href":"https:\/\/dev.sapien.com\/blog\/wp-json\/wp\/v2\/media?parent=48"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/dev.sapien.com\/blog\/wp-json\/wp\/v2\/categories?post=48"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/dev.sapien.com\/blog\/wp-json\/wp\/v2\/tags?post=48"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}